PHP Warning messages

[cuceta]

I was receiving lots of PHP warning messages about this plugin everytime i enable PHP error_reporting(). (Newsletter version 3.0.9)

These messages were coming from 2 files: plugins/newsletter/plugin.php and plugins/newsletter/includes/controls.php

In plugin/newsletter/plugins.php there is a method called is_admin_page() to check if we are in one of the plugin’s admin page. Its check for a index inside $_GET global variable even when there is no index, so a warning message is displayed

I’ve made a fix here: http://pastebin.com/KPnDXBfc

In plugin/newsletter/includes/controls.php the __constructor() method was trying to set some properties coming from $_POST and $_REQUEST global variables even when there were no indexes. Some warning messages were being displayed

I’ve made a fix here: http://pastebin.com/9TTHq426

Despite the messages this awesome plugin works perfectly

Hope it helps and sorry for my bad english

Thanks for this amazing plugin guys 😉

[Author]

Posts